Skip to content

Adding tests - #191

Merged
cbedwards-dfw merged 39 commits into
devfrom
adding_tests
Aug 10, 2026
Merged

Adding tests#191
cbedwards-dfw merged 39 commits into
devfrom
adding_tests

Conversation

@cbedwards-dfw

Copy link
Copy Markdown
Contributor

Added unit tests for almost all user-facing files, also many developer-only files. Fixed a few bugs identified in that process.

Removed styleguide.R and associated functions (no longer in use, but stored in snippets repo.

@cbedwards-dfw

cbedwards-dfw commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Address remaining issues:

  • calculate_stock_comp() accepts timestep 5 for Chinook even though its own error message says Chinook only has 1–4.
  • Snapshots are being git-ignored. Remove `tests/testthat/_snaps/
  • remove failed tests artefacts and add tests/testthat/_problems/, tests/testthat/testthat-problems.rds to gitignore
  • add test() to github actions.
  • Add minimum version of 1.1.0 for dplyr dependency to support the use of .by.

@cbedwards-dfw

Copy link
Copy Markdown
Contributor Author

Revision: most snapshots rely on local databases, and the associated tests won't be run by github checks. So I have simply negated the two snapshot files for which this is not the case.

@cbedwards-dfw

Copy link
Copy Markdown
Contributor Author

Note: this PR addresses #120

@cbedwards-dfw
cbedwards-dfw merged commit ac28abb into dev Aug 10, 2026
6 checks passed
@cbedwards-dfw
cbedwards-dfw deleted the adding_tests branch August 10, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant