-
Notifications
You must be signed in to change notification settings - Fork 0
fix: chunk the registration to the registry per-entry content-CID cap #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7587934
fix(engine): chunk the registration to the registry per-entry content…
FSM1 90a9432
fix: classify a register refusal on the registry's own discriminator
FSM1 fcaf4fb
fix(api): keep the registry's batch refusal from echoing the caller's…
FSM1 2d27cbd
fix(api): document the registry batch-refusal body in the OpenAPI con…
FSM1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { ApiProperty } from '@nestjs/swagger'; | ||
|
|
||
| /** | ||
| * The registry's batch routes answer 400 for a refusal the caller can never | ||
| * retry past. Clients classify on this stable `code`, so a 400 from anything | ||
| * that is NOT this gate stays unattributable (blueprint/api.md). | ||
| */ | ||
| export const REGISTRY_BATCH_REFUSED = 'REGISTRY_BATCH_REFUSED'; | ||
|
|
||
| /** The documented 400 body; `batchRefusedBody` returns exactly this shape. */ | ||
| export class BatchRefusedDto { | ||
| @ApiProperty({ example: 400 }) | ||
| statusCode!: number; | ||
|
|
||
| @ApiProperty({ | ||
| type: [String], | ||
| description: 'Constraint strings only — never the rejected entry', | ||
| }) | ||
| message!: string[]; | ||
|
|
||
| @ApiProperty({ example: 'Bad Request' }) | ||
| error!: string; | ||
|
|
||
| @ApiProperty({ enum: [REGISTRY_BATCH_REFUSED] }) | ||
| code!: string; | ||
| } | ||
|
|
||
| /** Nest stops synthesizing `statusCode`/`error` once an exception carries an | ||
| * object, so the whole envelope is built here rather than at each throw site. */ | ||
| export function batchRefusedBody(message: string[]): BatchRefusedDto { | ||
| return { statusCode: 400, message, error: 'Bad Request', code: REGISTRY_BATCH_REFUSED }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.