Clean up scrape leftovers in the ru_RU bank list - #1068
Open
a-vasyukov wants to merge 1 commit into
Open
Conversation
The bank list was scraped from banki.ru in 2015 with a grep/sed pipeline that did not finish the job: one name still carries a raw entity, ten more hold a double space where sed stripped an —, and 'K2 Банк' is spelled with a Latin K instead of the Cyrillic К of the real bank.
Author
|
Two weeks, no CI run — outside contributors need manual approval, so the added tests are verified One call here is yours rather than mine: the ten double spaces are collapsed to a single space, not The same defects exist in |
pwsdotru
approved these changes
Aug 25, 2026
pwsdotru
left a comment
There was a problem hiding this comment.
As native Russian speaker I confirm this changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
The docblock above
$banksinsrc/Provider/ru_RU/Payment.phprecords where the list came from:788 names scraped from banki.ru on 2015-04-04 with a
grep | iconv | sedpipeline. The pipelineleft three kinds of debris behind:
'Дж. П. Морган Банк'sed -r 's/—//'stripped a dash'Верхневолжский Ярославский филиал''K2 Банк'— LatinK(U+004B) instead of CyrillicК(U+041A)The real bank is АО «К2 Банк» (OGRN 1021500000103), spelled with a Cyrillic
К, so'K2 Банк'never matches a search for
'К2 Банк'and sorts as a Latin word.Double spaces are collapsed to a single space rather than restored to a dash: removing an obvious
artefact is a fix, while adding back a character that is not in the data would be a change to the
data set.
Latin letters in
'Эйч-Эс-Би-Си Банк (HSBC)'and'Ай-Си-Ай-Си-Ай Банк (ICICI)'are left alone —the source spells out the international brand in parentheses there, and that is intentional.
Author's checklist
Summary of changes
entity, collapse ten double spaces, replace the LatinKin'K2 Банк'parentheses
Regarding "avoid changing existing sets of data": no entry is added, removed or reordered, so a
given seed still selects the same positions in the same order. Only characters inside 12 of the 788
values change — the characters that are the defect.
The suite stays green: 1416 tests before, 1418 with the new ones, no failures.
Review checklist
CHANGELOG.md