Increase type strictness to prepare for Typescript 6

api/eslint.config.mjs

@@ -20,8 +20,9 @@ export default [
         languageOptions: {
             parser: tsParser,
         },
-	rules: { 
-		"@typescript-eslint/no-require-imports": "off" 
+	rules: {
+		"@typescript-eslint/no-require-imports": "off",
+		"@typescript-eslint/triple-slash-reference": "off"
 	},
     }
 ];

api/package.json

@@ -56,6 +56,9 @@
   "devDependencies": {
     "@types/express": "^5.0.6",
     "@types/express-session": "^1.18.2",
+    "@types/ini": "^4.1.1",
+    "@types/jest": "^30.0.0",
+    "@types/pdfkit": "^0.17.6",
     "@types/jest": "^30",
     "@types/node": "^26",
     "@typescript-eslint/eslint-plugin": "^8.52",

api/src/app.ts

@@ -1,7 +1,7 @@
-import * as express from "express";
-import * as cookieParser from "cookie-parser";
+import express from "express";
+import cookieParser from "cookie-parser";
 import * as path from "path";
-import * as logger from "morgan";
+import logger from "morgan";
 import Config from "./models/Config";
 
 const app = express();

api/src/jobs/Derivative.test.ts

@@ -16,8 +16,8 @@ describe("Derivative", () => {
 
     describe("run", () => {
         let job: Job;
-        let consoleErrorSpy;
-        let consoleLogSpy;
+        let consoleErrorSpy: jest.SpyInstance;
+        let consoleLogSpy: jest.SpyInstance;
         beforeEach(() => {
             job = {
                 data: {

api/src/jobs/Derivative.ts

@@ -12,7 +12,7 @@ class Derivative implements QueueJob {
 
         // For each page
         const order = PageOrder.fromJob(job.data);
-        const generatingPromises = [];
+        const generatingPromises: Promise<string>[] = [];
         order.raw.forEach((page) => {
             // For each size
             const image = ImageFile.build(`${job.data.dir}/${page.filename}`);

api/src/models/AudioFile.ts

@@ -8,7 +8,7 @@ class AudioFile extends AbstractAVFile {
         return new AudioFile(filename, dir, Config.getInstance());
     }
 
-    static fromRaw(raw: Record<string, string>, config: Config = null): AudioFile {
+    static fromRaw(raw: Record<string, string>, config: Config | null = null): AudioFile {
         return new AudioFile(raw.filename, raw.label, config ?? Config.getInstance());
     }
 }

api/src/models/Category.ts

@@ -5,7 +5,7 @@ import path = require("path");
 
 import Job from "./Job";
 
-export class CategoryRaw {
+export interface CategoryRaw {
     category: string;
     jobs: Array<string>;
 }