Fix overflow in point-set distance norms - #4961
Closed
FlorianPfaff wants to merge 2 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Owner
Author
|
Closing as low value. This changes core OSPA/GOSPA distance evaluation solely for coordinate differences around 1e308. That scale is not a meaningful supported tracking regime, so the special normalization path and regression surface are not justified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
src/pyrecest/utils/metrics.pyRoot cause
_pairwise_distances()delegated directly tonp.linalg.norm. For a finite difference vector such as[1e308, 1e308], the internal sum of squares overflows even though the Euclidean norm, approximately1.4142e308, is representable. OSPA and GOSPA then clip the resulting infinity to the cutoff and overstate localization error whenever the cutoff exceeds the true distance.Impact
Built-in OSPA/GOSPA distances now preserve representable Euclidean distances at extreme finite coordinate scales. Ordinary-scale behavior and custom
distance_fnhandling are unchanged.This replaces the valid bug fix attempted in #4951 with the requested focused implementation: no wrapper module, no duplicated metrics implementation, and no import-time monkey patching.
Validation
np.errstate(over="raise", invalid="raise")np.hypot(1e308, 1e308)main; final diff is limited to one in-place source change and one regression fileGitHub Actions provides the full supported-version and backend validation matrix.