Stabilize UKF covariance symmetrization - #4962
Closed
FlorianPfaff wants to merge 3 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Owner
Author
|
Closing as low value despite the green matrix. It adds a specialized symmetrization algorithm solely to preserve covariance entries near the maximum finite float64 value. Such covariances are not a meaningful UKF operating regime, and the added numerical path would burden core filter code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
float64limitRoot cause
src/pyrecest/filters/_ukf.pyused0.5 * (P + P.T). For a symmetric covariance containingnp.finfo(np.float64).max, the intermediate sum overflows even though the mathematical average remains finite.Impact
A valid finite process covariance could raise
FloatingPointErrorunder strict NumPy error handling or become non-finite during UKF prediction. The update path used the same vulnerable expression.Fix
The new helper scales each transposed entry pair by its largest magnitude before averaging, then restores the scale. This keeps finite pairs within
[-1, 1]during the intermediate addition and also preserves subnormal values.Validation
FloatingPointError: overflow encountered in addnp.finfo(np.float64).maxexactly and regenerates finite sigma pointspython -m py_compilemainremains limited to exactly two changed files