Skip to content

Make calibration hotfixes reload-safe - #4970

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/fix-calibration-reload-recursion
Aug 3, 2026
Merged

Make calibration hotfixes reload-safe#4970
FlorianPfaff merged 2 commits into
mainfrom
agent/fix-calibration-reload-recursion

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Bug

pyrecest.calibration patches helpers in calibration.time_offset and calibration.bias at import time. On importlib.reload(pyrecest.calibration), the module previously captured its already-patched wrappers as the new “base” functions. Because those wrappers resolve their base functions through the reloaded module globals, aggregation and bias-calibration calls then recurse until RecursionError.

This affects notebook autoreload, interactive development, test isolation, and applications that deliberately reload modules.

Fix

  • preserve the original time-offset and bias helper functions on their owning modules before applying calibration patches;
  • always bind reload-time wrappers to those preserved originals;
  • make the public aggregate_time_offset_sweeps patch reload-idempotent as well;
  • add a regression that reloads pyrecest.calibration twice and exercises both aggregation and bias-example generation after each reload.

Validation

  • reproduced the pre-fix aggregation and bias recursion in an isolated harness matching the current patch/reload behavior;
  • verified the patched wrappers survive three consecutive reloads in the same harness;
  • syntax-compiled the modified module and regression test;
  • branch is 2 commits ahead of and 0 behind current main, with changes limited to the calibration initializer and one focused test.

GitHub Actions will provide the full supported Python/backend and lint validation matrix.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 25.86s
✅ JSON prettier 7 0 0 0 1.12s
✅ JSON v8r 7 0 0 4.67s
✅ MARKDOWN markdownlint 68 0 0 0 1.93s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.56s
✅ PYTHON black 1810 57 0 0 95.01s
✅ PYTHON isort 1810 89 0 0 2.81s
✅ REPOSITORY betterleaks yes no no 2.26s
✅ REPOSITORY checkov yes no no 54.67s
✅ REPOSITORY gitleaks yes no no 17.47s
✅ REPOSITORY git_diff yes no no 0.3s
✅ REPOSITORY secretlint yes no no 80.6s
✅ REPOSITORY syft yes no no 6.92s
✅ REPOSITORY trivy-sbom yes no no 7.42s
✅ REPOSITORY trufflehog yes no no 32.12s
✅ YAML prettier 11 0 0 0 0.72s
✅ YAML v8r 11 0 0 11.69s
✅ YAML yamllint 11 0 0 0.6s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review August 3, 2026 08:45
@FlorianPfaff
FlorianPfaff merged commit b86dc81 into main Aug 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant