Normalize positional PyTorch FFT dimensions - #4973
Merged
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 3, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
The PyTorch FFT compatibility wrappers normalized NumPy-style dimension values only when
dim,axis, oraxeswas supplied by keyword. When the equivalent argument was passed positionally, the wrapper forwarded NumPy scalar or array values directly to Torch.This made otherwise valid calls fail, for example:
rfft(values, None, np.array(0))fftshift(values, np.array([0]))fftn(values, None, np.array([0]))Torch rejects those positional NumPy values even though the corresponding NumPy FFT calls accept them. Positional empty dimensions also bypassed the wrapper's existing no-op handling for FFT shifts.
Fix
dimargument for each wrapper;The fix covers
rfft,irfft,fftshift,ifftshift,fftn, andifftn.Validation
TypeErrorfor positional NumPy scalar and array dimensions;np.array(0),np.int64(0), NumPy axis arrays, sequences containing NumPy scalar arrays, and empty positional axes;main, with exactly two changed files.