Fix overflow in tracklet edge distances - #4974
Closed
FlorianPfaff wants to merge 2 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Owner
Author
|
Closing as low value. This hardens tracklet rotation only for coordinates near the floating-point limit (around 1e308), which is not a practical supported state-estimation regime. The added scale-specific machinery would increase complexity without meaningful application benefit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
constant_velocity_edge_cost()computed endpoint displacement withnumpy.linalg.norm. For large but finite coordinates such as[1e308, 1e308], the internal sum of squares overflows even though the Euclidean norm (about1.4142e308) is still representable.The resulting infinite edge cost is filtered out by
build_tracklet_adjacency(), so a mathematically valid and feasible tracklet transition can disappear from the association graph solely because of an avoidable intermediate overflow.Fix
hypotreductionValidation
numpy.linalg.norm([1e308, 1e308])overflows to infinitynumpy.hypot(1e308, 1e308)and preserves a[3, 4]displacement cost of5The repository's normal pull-request checks provide the full integration matrix.