Count higher-rank measurement batches correctly - #4976
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 3, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
evaluate_for_file()derivesn_meas_at_individual_time_stepfrom each saved per-step measurement payload. It correctly uses the first axis as the measurement count for two-dimensional arrays, but leaves the zero-initialized count unchanged for arrays with rank three or higher.For example, a payload with shape
(3, 2, 2)is reported as containing zero measurements instead of three. This can misconfigure downstream evaluation control flow for matrix-, image-, or tensor-valued measurements stored as a batch.Fix
shape[0]as the number of measurements;Validation
[0, 0, 0]instead of[3, 0, 4];main, with exactly two changed files.GitHub Actions should provide the full repository validation matrix.