Skip to content

Count higher-rank measurement batches correctly - #4976

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/count-higher-rank-file-measurements
Aug 3, 2026
Merged

Count higher-rank measurement batches correctly#4976
FlorianPfaff merged 2 commits into
mainfrom
agent/count-higher-rank-file-measurements

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Bug

evaluate_for_file() derives n_meas_at_individual_time_step from each saved per-step measurement payload. It correctly uses the first axis as the measurement count for two-dimensional arrays, but leaves the zero-initialized count unchanged for arrays with rank three or higher.

For example, a payload with shape (3, 2, 2) is reported as containing zero measurements instead of three. This can misconfigure downstream evaluation control flow for matrix-, image-, or tensor-valued measurements stored as a batch.

Fix

  • preserve the existing scalar and one-dimensional conventions;
  • treat every payload with at least two dimensions uniformly, using shape[0] as the number of measurements;
  • add a regression covering nonempty rank-3 and rank-4 batches plus an empty higher-rank batch.

Validation

  • focused regression against current behavior: 1 failed, with actual counts [0, 0, 0] instead of [3, 0, 4];
  • focused regression with the patch: 1 passed;
  • syntax parsing passed for the modified source and new test;
  • branch comparison: 2 commits ahead, 0 behind main, with exactly two changed files.

GitHub Actions should provide the full repository validation matrix.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 23.59s
✅ JSON prettier 7 0 0 0 0.77s
✅ JSON v8r 7 0 0 4.16s
✅ MARKDOWN markdownlint 68 0 0 0 1.67s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.75s
✅ PYTHON black 1810 56 0 0 86.19s
✅ PYTHON isort 1810 88 0 0 2.24s
✅ REPOSITORY betterleaks yes no no 2.85s
✅ REPOSITORY checkov yes no no 48.68s
✅ REPOSITORY gitleaks yes no no 15.88s
✅ REPOSITORY git_diff yes no no 0.21s
✅ REPOSITORY secretlint yes no no 76.9s
✅ REPOSITORY syft yes no no 5.95s
✅ REPOSITORY trivy-sbom yes no no 4.7s
✅ REPOSITORY trufflehog yes no no 31.1s
✅ YAML prettier 11 0 0 0 0.69s
✅ YAML v8r 11 0 0 11.71s
✅ YAML yamllint 11 0 0 0.56s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review August 3, 2026 08:44
@FlorianPfaff
FlorianPfaff merged commit 4c9e151 into main Aug 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant