Reject out-of-range index-matrix fill values - #4977
Closed
FlorianPfaff wants to merge 2 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Owner
Author
|
Closing as low value. This only changes the exception produced for an already-invalid integer sentinel outside the representable int64 range. Supported sentinel values are unaffected, so the maintenance and test surface is not justified by practical user impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
tracks_to_index_matrix()validates thatfill_valueis a negative integer, but did not validate that it is representable by the integer matrix it allocates. A value belownumpy.iinfo(numpy.int64).mintherefore passed the public validation and failed later inside the backend allocator with a rawOverflowError.For example,
fill_value=numpy.iinfo(numpy.int64).min - 1reachednumpy.full(..., dtype=int)and raisedOverflowError: Python int too large to convert to C long.Fix
int64range with a deterministicValueError;int64minimum boundary;Validation
OverflowErrorthrough the current module in an isolated NumPy-backend harness;The repository's pull-request workflows provide the full supported Python/backend, lint, packaging, documentation, and security validation matrix.