Fix 3D ellipsoid scaling around its center - #4978
Merged
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 3, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
plot_ellipsoid_3d()appliedscaling_factorto the already translated surface coordinates. For an ellipsoid centered away from the origin, changing its scale therefore moved the center as well as resizing the axes.For example, an identity ellipsoid centered at
[3, 4, 5]withscaling_factor=2produced a vertical extent from8to12, centered at10, instead of the correct extent from3to7, centered at5.Root cause
The helper first added
centerto the unit-sphere transform and then multipliedx,y, andzbyscaling_factorinplot_surface(). Algebraically, this computedscale * (shape @ point + center)rather thancenter + scale * shape @ point.Fix
scaling_factoronly to the transformed ellipsoid offsets;centerafterward;Validation
z=12wherez=7is expected;main, with changes limited to the plotting helper and one regression test.