Fix SE(3) plot-state sample indexing - #4982
Merged
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 3, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
AbstractSE3Distribution.plot_state()indexed sampled SE(3) states as if samples were stored in columns. PyRecEst's distribution sampling contract returns an array shaped(n_samples, state_dim), includingAbstractDiracDistribution.sample().For two SE(3) samples shaped
(2, 7), the previous implementation iterated over the seven state coordinates and assembled seven malformed vectors of shape(2,). It mixed coordinates from different samples and could then fail insideplot_point()or plot incorrect poses.Fix
samples.shape[0]);showMarginalized=Truebehavior by combining each sampled quaternion with the mode's linear position;Validation
(2, 7)became 7 vectors shaped(2,);(7,)and matches the original samples;main;GitHub Actions should run the repository's full supported backend and test matrix.