Skip to content

Make TrackManager state replacement atomic - #4992

Draft
FlorianPfaff wants to merge 4 commits into
mainfrom
agent/fix-track-manager-atomic-state
Draft

Make TrackManager state replacement atomic#4992
FlorianPfaff wants to merge 4 commits into
mainfrom
agent/fix-track-manager-atomic-state

Conversation

@FlorianPfaff

@FlorianPfaff FlorianPfaff commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Bug

TrackManager.filter_state cleared the existing track bank and reset _next_track_id before validating every replacement entry. If a later initializer was invalid, the setter raised after partially replacing the manager and permanently discarded the prior valid state.

Fix

  • normalize the complete replacement iterable before mutating manager state
  • only clear and rebuild the track bank after all entries are valid
  • preserve existing tracks and ID allocation when validation fails

Regression coverage

The new test installs one valid track, attempts a replacement containing a valid first entry and an invalid second entry, and verifies that the original track list, track object, point estimate, and next ID remain unchanged.

Validation

  • focused TrackManager regression suite passed before the tested source commit was created
  • current PR CI: lint, docs, documentation examples, security checks, and dependency review are green
  • package/minimal-install and NumPy, PyTorch, and JAX test matrices are running

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 28.12s
✅ JSON prettier 7 0 0 0 1.05s
✅ JSON v8r 7 0 0 3.63s
✅ MARKDOWN markdownlint 68 0 0 0 1.75s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.83s
✅ PYTHON black 1816 59 0 0 85.47s
✅ PYTHON isort 1816 91 0 0 2.86s
✅ REPOSITORY betterleaks yes no no 2.56s
✅ REPOSITORY checkov yes no no 49.48s
✅ REPOSITORY gitleaks yes no no 14.27s
✅ REPOSITORY git_diff yes no no 0.49s
✅ REPOSITORY secretlint yes no no 76.88s
✅ REPOSITORY syft yes no no 5.65s
✅ REPOSITORY trivy-sbom yes no no 5.92s
✅ REPOSITORY trufflehog yes no no 31.25s
✅ YAML prettier 11 0 0 0 0.72s
✅ YAML v8r 11 0 0 11.11s
✅ YAML yamllint 11 0 0 0.54s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant