#6269 improve img srcset sanitation checks - #6270
Open
martgil wants to merge 1 commit into
Open
Conversation
martgil
marked this pull request as draft
August 5, 2026 12:25
martgil
marked this pull request as ready for review
August 7, 2026 10:08
Collaborator
Author
|
Hi @sosnovsky - This one is ready for a review. Thank you! |
sosnovsky
reviewed
Aug 7, 2026
| if (node.tagName === 'IMG') { | ||
| const img = node as HTMLImageElement; // Narrow type to HTMLImageElement | ||
| const src = img.getAttribute('src'); | ||
| const srcset = img.getAttribute('srcset'); |
Collaborator
There was a problem hiding this comment.
I think better solution will be to ignore srcset property by removing it before parsing with img.removeAttribute('srcset');, since basic src support is enough for loading images and srcset just adds support for responsive images. Gmail doesn't support srcset property too, as noted at https://www.caniemail.com/features/html-srcset/
However, we should apply similar URL check for src property, since attacker can use the same /Logout link there too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves img srcset sanitation checks on remote images loaded in content script.
close #6269
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):