Decide the means the core speaks HTTP with: the protocol crate, not a client (#292) - #295
Closed
iderex wants to merge 1 commit into
Closed
Decide the means the core speaks HTTP with: the protocol crate, not a client (#292)#295iderex wants to merge 1 commit into
iderex wants to merge 1 commit into
Conversation
… client (#292) Record 0292 decides that the core writes and reads HTTP/1.1 through `ureq-proto`, taken with `default-features = false` and the `client` feature alone, driven over a socket the core opens and the TLS stream 0243 decided. The manifest carries the entry with the clause of 0103 that admits it and the condition that retires it, the lockfile carries the seven packages it resolves to, and the index in `docs/decisions/README.md` names the record. What goes wrong without it: the socket #27 writes is written against the first package that compiles, and the first package that compiles for HTTP in this ecosystem is a client. A client holds 0027's bounds as its own settings on a clock 0102's injected source cannot reach, adds a proxy read from the environment to the destinations 0069 fixed, and drops a cancelled body instead of reading it to 0027's bound. None of those reversals reddens a gate here, because the invariants register reads `src/` and judges no dependency, so the record is the only place the reversal is refused. I re-took every count in the record with `--locked` in the scratch crates the readings came from and they reproduce to the package, and I re-ran every source reading against the vendored and registry sources at the versions named. Build, test, lint, format, invariants, decision-records, statements, doc-paths, fixture-scrub, dependencies and all seven target triples pass on this tree; the thread-detector leg cannot link on this machine and is the runner's verdict alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #296.
This pull request carried commit db06b26 without the
Signed-off-bytrailer that theDCO sign-offcheck requires, and that check refused it. Adding the trailer rewrites the commit, and a pushed branch is never rewritten here, so the corrected commit was pushed under a new branch name and #296 carries it with the same body and the same tree. Nothing else was wrong with this change, and nothing from it is lost. This body carried the full evidence before this edit; it now lives on #296.#292 is the issue, and it is closed by #296 rather than by this one.