Carry the catalogue the publication run built - #180
Open
flowfin-publisher[bot] wants to merge 1 commit into
Open
Carry the catalogue the publication run built#180flowfin-publisher[bot] wants to merge 1 commit into
flowfin-publisher[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publication run built docs/manifest.json from the declarations, and what main carries at that path is different, so this request carries the difference. It closes nothing. The run proposes and merges nothing itself, and the merge stays a person's step in front of the served directory, which is what decisions/release-procedure.md asks for.
The mechanism that opened this was argued in #154.
The checks on this request have not started, and they will not start on their own. A request opened with a run's own token creates no workflow run, so the jobs the ruleset requires are absent rather than red. Closing this request and reopening it starts them. Read the verdict before merging.