i18n copy extraction, notification a11y, batch progress announcements (#682-#686) - #702
Open
Joel234-png wants to merge 1 commit into
Open
Conversation
…nouncements - Extract create-form.tsx and stream detail page strings into lib/copy/ modules as a first i18n-prep step (FlowwStar#682, FlowwStar#683). - Add roving focus + Up/Down arrow-key navigation to the notification dropdown, focusing the first item (or panel) on open (FlowwStar#684). - Add an aria-live="polite" status region announcing batch-create start and outcome to screen readers (FlowwStar#686). Closes FlowwStar#682 Closes FlowwStar#683 Closes FlowwStar#684 Closes FlowwStar#686
|
@Joel234-png Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/app/create/create-form.tsxandapp/app/stream/[id]/page.tsxintolib/copy/create-form.tsandlib/copy/stream-detail.tsrespectively — labels, buttons, placeholders, help text, and validation/toast messages, including dynamic ones (as parameterized functions). Preset-label arrays (duration/cliff/interval presets, auto-withdraw strategies) were extracted too since they're rendered directly as UI text.components/layout/notification-bell.tsx— opening the dropdown now moves focus to the first notification item (or the panel itself when empty), and Up/Down arrow keys roam between items via a roving-focus pattern (role="menu"/role="menuitem", refs per item).app/app/create/batch/page.tsx— added a screen-reader-onlyrole="status" aria-live="polite"region announcing batch execution start and outcome. Note:createStreamsBatchsubmits the whole batch as a single on-chain transaction rather than one call per row, so there's no real per-row progress to announce (the issue's example "Creating stream 3 of 10" phrasing doesn't reflect how execution actually works here) — the region instead announces "Creating N streams…" then the final success/failure outcome, which is the accurate, honest signal available from this API.Closes #682
Closes #683
Closes #684
Closes #686