Enhance scatter! to support const destination with no derivative output - #768
Open
Parvm1102 wants to merge 1 commit into
Open
Enhance scatter! to support const destination with no derivative output#768Parvm1102 wants to merge 1 commit into
Parvm1102 wants to merge 1 commit into
Conversation
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Parvm1102
force-pushed
the
enzyme-scatter-const-dst
branch
from
August 20, 2026 15:25
3349ae5 to
649e5e8
Compare
Contributor
Author
|
Resolved the Merge conflicts |
Contributor
Author
|
@CarloLucibello please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scatter!with aConstdst hit an internal assertion:The new rule handles this. The scatter still runs, and nothing flows
back to
src, since aConstdst carries no derivative.Dropping the assertion on its own would not have been enough: the primal was
only run for
Duplicated/BatchDuplicated, so aConstdst would haveskipped the scatter entirely and left dst unwritten. The test checks that the
mutation still happens, not just that it no longer errors.
Fixes #766.
PR Checklist