fix(ping-sdk): fix import order for all files in ping sdk

[vatsalparikh]

Merge after 2.2 release of Ping SDK

Summary

• Adds `eslint-plugin-simple-import-sort` to enforce consistent import ordering across all packages
• Adds `@typescript-eslint/consistent-type-imports` to enforce separate `import type` statements
• Adds `import/consistent-type-specifier-style` to split mixed value/type imports into separate declarations
• Fixes pre-existing inline `import()` type annotation violations in `oidc-client` and `davinci-client`
• Fixes `@nx/dependency-checks` in `journey-client` incorrectly adding test-only deps to `dependencies` during `--fix` runs
• Preserves Effect Schema declaration-merging `interface` pattern in `mock-api-v2` schemas (protected by existing local ESLint config)

Test plan

• `pnpm nx affected -t lint` passes with no errors
• `pnpm nx affected -t typecheck` passes with no errors
• `pnpm nx affected -t build` passes with no errors
• CI passes end-to-end

[changeset-bot]

⚠️ No Changeset found

Latest commit: caeea2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 71849b0b-5d60-4278-b7cc-cc3932d6cb54

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-import-order

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit caeea2f

Command	Status	Duration	Result
nx run-many -t build --no-agents	✅ Succeeded	<1s	View ↗
nx affected -t build lint test typecheck e2e-ci	✅ Succeeded	2m 57s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-09-18 23:08:43 UTC

[pkg-pr-new]

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@683

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@683

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@683

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@683

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@683

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@683

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@683

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@683

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@683

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@683

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@683

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@683

commit: caeea2f

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (eafe277) to head (caeea2f).
⚠️ Report is 157 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #683       +/-   ##
===========================================
+ Coverage   18.07%   96.29%   +78.22%     
===========================================
  Files         155        1      -154     
  Lines       24398       81    -24317     
  Branches     1203       17     -1186     
===========================================
- Hits         4410       78     -4332     
+ Misses      19988        3    -19985     

Files with missing lines	Coverage Δ
...s/iframe-manager/src/lib/iframe-manager.effects.ts	96.29% <ø> (+95.35%)	⬆️

... and 154 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Deployed b51e1a9 to https://ForgeRock.github.io/ping-javascript-sdk/pr-683/b51e1a97ec2ad3ab9e62325d6771b93f62a79078 branch gh-pages in ForgeRock/ping-javascript-sdk

[github-actions]

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/device-client - 0.0 KB (-10.0 KB, -100.0%)
🔻 @forgerock/journey-client - 0.0 KB (-94.0 KB, -100.0%)

📊 Minor Changes

📈 @forgerock/device-client - 10.3 KB (+0.3 KB)
📈 @forgerock/sdk-types - 9.1 KB (+0.0 KB)
📈 @forgerock/journey-client - 94.3 KB (+0.2 KB)
📉 @forgerock/recognize - 4284.4 KB (-0.0 KB)
📈 @forgerock/oidc-client - 35.9 KB (+0.4 KB)
📈 @forgerock/storage - 1.5 KB (+0.0 KB)
📉 @forgerock/iframe-manager - 3.2 KB (-0.0 KB)
📈 @forgerock/sdk-logger - 1.6 KB (+0.0 KB)
📈 @forgerock/sdk-oidc - 5.8 KB (+0.0 KB)
📈 @forgerock/sdk-request-middleware - 4.6 KB (+0.0 KB)
📈 @forgerock/sdk-utilities - 18.8 KB (+0.0 KB)
📉 @forgerock/protect - 144.6 KB (-0.0 KB)
📈 @forgerock/davinci-client - 59.7 KB (+0.1 KB)

---

15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

• Current Size: Total gzipped size of all files in the package's dist directory
• Baseline: Comparison against the latest build from the main branch
• Files included: All build outputs except source maps and TypeScript build cache
• Exclusions: .map, .tsbuildinfo, and .d.ts.map files

---

_{🔄 Updated automatically on each push to this PR}

[SteinGabriel]

Other than 2 stale and 1 missing copyright header, these changes look good to merge.

Stale:

• e2e/davinci-suites/playwright.config.ts
• e2e/journey-suites/playwright.config.ts

Missing:

• e2e/oidc-suites/playwright.config.ts

[vatsalparikh]

Other than 2 stale and 1 missing copyright header, these changes look good to merge.

Stale:

• e2e/davinci-suites/playwright.config.ts
• e2e/journey-suites/playwright.config.ts

Missing:

• e2e/oidc-suites/playwright.config.ts

Thanks, updated / created copyright header for these files!

[nx-cloud]

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

We investigated the oidc-suites:e2e-ci--src/logout.spec.ts failure and determined it is an environment issue, not a code regression. The Playwright test timed out waiting for PingAM's login UI to render — a symptom of the PingAM service being unavailable during this CI run, with no causal link to the PR's import-order changes. Re-running CI once the PingAM service is healthy should resolve the failure.

No code changes were suggested for this issue.

Trigger a rerun:

View detailed reasoning on Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}