feat: add AM mediation check to WebAuthn and export storage config types - #762
vatsalparikh wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: b4b6408 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit b4b6408
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
===========================================
+ Coverage 18.07% 96.29% +78.22%
===========================================
Files 155 1 -154
Lines 24398 81 -24317
Branches 1203 17 -1186
===========================================
- Hits 4410 78 -4332
+ Misses 19988 3 -19985 🚀 New features to boost your workflow:
|
|
Deployed 1b9fa3e to https://ForgeRock.github.io/ping-javascript-sdk/pr-762/1b9fa3e7bf7f944455014acef1d0d913b4a23c89 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-10.0 KB, -100.0%) 📊 Minor Changes📈 @forgerock/journey-client - 94.0 KB (+0.3 KB) ➖ No Changes➖ @forgerock/device-client - 10.0 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
042f664 to
315063f
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We reviewed all 16 failing e2e tasks and determined they are pre-existing infrastructure failures unrelated to this PR's changes. The errors — recursive Nx task loops, localhost port conflicts (5829, 8443), and downstream connection-refused failures — appear identically on the main branch, confirming they were not introduced here. No code fix is needed; a CI rerun should resolve the transient port contention.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
da7beb5 to
f7abc49
Compare
f7abc49 to
b4b6408
Compare
5 participants
Merge after 2.2 release
JIRA ticket
https://pingidentity.atlassian.net/browse/SDKS-5367
Summary
WebAuthn.isConditionalMediationSupportednow optionally accepts aJourneyStepand, when provided, also checks that AM requested conditional mediation via the WebAuthn metadata (meta.mediation === 'conditional')BrowserStorageConfig,CustomStorageConfigfrom@forgerock/storageandCustomStorageObjectfrom@forgerock/sdk-typesoffoidc-client's types entry point