test(javascript): migrate P1/DaVinci E2E tests to new tenant - #135
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8972f04 to
665382c
Compare
SteinGabriel
left a comment
There was a problem hiding this comment.
I noticed that VITE_PINGONE_ENV_ID in javascript/reactjs-todo-journey/playwright.conf still points to the old tenant.
Should the tests for the journey app be migrated to the new tenant as well?
@SteinGabriel Good catch! It's fixed now. Please re-review. Thanks! |
vatsalparikh
left a comment
There was a problem hiding this comment.
Looks good!
Tested all three apps, davinci, login widget, oidc. Sign in, sign out, protect work as expected!
Migrates JS
reactjs-todo-davinciand P1reactjs-todo-oidcE2E tests to new tenant. Creates a client in new tenant shared by all DaVinci sample app tests (Sample Apps Client). OIDC tests reuseOIDC Clientclient in new tenant.This PR also pins the login widget dep to an exact version (2.0.0) to fix failing CI (application won't start using
@forgerock/login-widget@2.1.0).You can review the new list of flows here:
https://docs.google.com/spreadsheets/d/1VdL7EONaj37aiyq6TKNm5Jcusf7tuBp3dSe-cO1t94Y/edit?usp=sharing