Skip to content

test(javascript): migrate P1/DaVinci E2E tests to new tenant - #135

Merged
ancheetah merged 3 commits into
mainfrom
migrate-dv-js-e2e-tenant
Sep 11, 2026
Merged

ancheetah merged 3 commits into
mainfrom
migrate-dv-js-e2e-tenant

Conversation

@ancheetah

@ancheetah ancheetah commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Migrates JS reactjs-todo-davinci and P1 reactjs-todo-oidc E2E tests to new tenant. Creates a client in new tenant shared by all DaVinci sample app tests (Sample Apps Client). OIDC tests reuse OIDC Client client in new tenant.

This PR also pins the login widget dep to an exact version (2.0.0) to fix failing CI (application won't start using @forgerock/login-widget@2.1.0).

You can review the new list of flows here:
https://docs.google.com/spreadsheets/d/1VdL7EONaj37aiyq6TKNm5Jcusf7tuBp3dSe-cO1t94Y/edit?usp=sharing

Screenshot 2026-09-08 at 1 52 43 PM Screenshot 2026-09-08 at 1 53 20 PM

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4c4a590e-44f6-4afc-bbb8-632496a36b6b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ancheetah
ancheetah force-pushed the migrate-dv-js-e2e-tenant branch from 8972f04 to 665382c Compare September 8, 2026 19:10
@ancheetah ancheetah changed the title test(reactjs-todo-davinci): migrate E2E tests to new tenant test(javascript): migrate P1/DaVinci E2E tests to new tenant Sep 8, 2026
@ancheetah
ancheetah marked this pull request as ready for review September 8, 2026 20:37
cerebrl
cerebrl previously approved these changes Sep 10, 2026

@SteinGabriel SteinGabriel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that VITE_PINGONE_ENV_ID in javascript/reactjs-todo-journey/playwright.conf still points to the old tenant.

Should the tests for the journey app be migrated to the new tenant as well?

@ancheetah

Copy link
Copy Markdown
Contributor Author

I noticed that VITE_PINGONE_ENV_ID in javascript/reactjs-todo-journey/playwright.conf still points to the old tenant.

Should the tests for the journey app be migrated to the new tenant as well?

@SteinGabriel Good catch! It's fixed now. Please re-review. Thanks!

@vatsalparikh vatsalparikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Tested all three apps, davinci, login widget, oidc. Sign in, sign out, protect work as expected!

@ancheetah
ancheetah merged commit bd21edd into main Sep 11, 2026
17 checks passed
@ancheetah
ancheetah deleted the migrate-dv-js-e2e-tenant branch September 11, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants