feat(reactjs-todo-journey): webauthn autofill - #136
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
773c334 to
d4d0a8f
Compare
| const callbacksForm = <form | ||
| className="cstm_form" | ||
| onSubmit={(event) => { | ||
| event.preventDefault(); | ||
| // Indicate form processing | ||
| setSubmittingForm(true); | ||
| // set currently rendered step as step to be submitted | ||
| setSubmissionStep(renderStep); | ||
| }} | ||
| > | ||
| {formFailureMessage ? <Alert message={formFailureMessage} type="error" /> : null} | ||
| { | ||
| /** | ||
| * Map over the callbacks in renderStep and render the appropriate | ||
| * component for each one. | ||
| */ | ||
| renderStep?.callbacks.map(mapCallbacksToComponents) | ||
| } | ||
| <Button buttonText={formMetadata.buttonText} submittingForm={submittingForm} /> | ||
| </form> |
There was a problem hiding this comment.
Non-blocking: can we surround this assignment with parentheses, fix the indent and add a semicolon?
vatsalparikh
left a comment
vatsalparikh
left a comment
There was a problem hiding this comment.
Code looks good!
My expectation from the various autofill journeys is that the product behavior / UX should be to fall back to login page if a journey has both login (user / pass) and webauthn (autofill). A user should never see a popup. But that's a product case.
As far as this sample app is concerned, demonstrating registration, authentication with webauthn, and authentication with autofill is sufficient.
4ec0f24
d4d0a8f to
4ec0f24
Compare
3 participants
https://pingidentity.atlassian.net/browse/SDKS-4579
http://localhost:8443/login?journey=TEST_AutofillPasskeyWebAuthn_autocomplete_conditional