Skip unsupported geometrically bounded surface representations - #25
Open
Jassy930 wants to merge 1 commit into
Open
Skip unsupported geometrically bounded surface representations#25Jassy930 wants to merge 1 commit into
Jassy930 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Summary
Some STEP exports include auxiliary
GEOMETRICALLY_BOUNDED_SURFACE_SHAPE_REPRESENTATIONentities alongside supportedB-Rep representations.
Foxtrot can parse these entities, but the triangulation traversal previously
treated them as unknown root representations and panicked, aborting otherwise
usable solid geometry.
This change:
Entity::GeometricallyBoundedSurfaceShapeRepresentation;Scope
This is a deliberately narrow fallback.
It does not implement tessellation for geometrically bounded surface
representations, and it does not replace the existing catch-all panic with a
blanket skip. Other unknown root representation types still fail as before.
The regression test verifies that:
Verification
Red/green regression test:
cargo test -p triangulate --test representation_fallback -- --nocaptureBefore the source change, the new test panics when traversal reaches the
GeometricallyBoundedSurfaceShapeRepresentation. After the source change, itpasses.
Additional checks:
All tests and checks pass with Rust and Cargo 1.96.0. Existing compiler and
future-compatibility warnings remain unchanged.