fix compilation errors/warnings + expose RecordLog in BP - #1
Open
jacopomaroli wants to merge 2 commits into
Open
fix compilation errors/warnings + expose RecordLog in BP#1jacopomaroli wants to merge 2 commits into
jacopomaroli wants to merge 2 commits into
Conversation
…replace monolithic headers, fix dangling Message pointer in AsyncTask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR achieves the following:
1 - exposes RecordLog in Blueprint. The use case is allowing manual log entries in shipping builds. Compilation would otherwise strip those.
This could also be achieved by modifying LogMessage/LogJson to call RecordLog directly instead of UE_LOG, but that approach is more invasive to existing code.
2 - when I tried to compile this in UE 5.8.0 I got the following errors and warnings
This PR tackles them all and achieves a clean compilation.
I Added Category specifiers to all UPROPERTY macros, included CoreMinimal.h before THIRD_PARTY_INCLUDES macros in RL_UUIDv7.h, replaced monolithic JsonUtilities.h and UMG.h includes with targeted headers
3 - The Message pointer was captured directly in an AsyncTask lambda, but the log system reuses that buffer. Subsequent calls overwrite it before the lambda executes, resulting in empty strings. Fixed by copying to an FString before capture.