Spectral function for SBN - #461
Open
sjgardiner wants to merge 44 commits into
Open
Conversation
sjgardiner
force-pushed
the
gardiner/sf-sbn
branch
from
September 16, 2025 14:04
8bf571b to
df45fc6
Compare
Add unified QEL cross-section framework with hadron tensor infrastructure
Introduces a hadron-tensor-based formulation for quasi-elastic cross
section calculations, replacing direct amplitude evaluation with a
contraction of leptonic and hadronic tensors.
New components:
- HadronTensorInterface(I) and Rank2LorentzTensorI: base classes for
rank-2 Lorentz tensor manipulation and contraction. New we only
implement the one body current. We will introduction two body
currents and interference in the future.
- LeptonTensor and ManualResponseTensor: leptonic and hadronic tensor
implementations
- UnifiedQELPXSec: tensor-contraction-based QEL cross-section algorithm
- KellyELFormFactorsModel: Kelly parametrization of nucleon EM form
factors, it is dipole model, new to GENIE
- LwlynSmithFFEM: electromagnetic variant of the Llewellyn-Smith
form-factor model
- onebody_currents_sf: one-body current operators for spectral
function calculations
- Spectral function tables for 12C, 16O, and 40Ar (p/n)
Updates SpectralFunc to interface with the new framework, registers
new algorithms in master_config.xml and per-algorithm XML configs,
and adjusts Makefile and LinkDef entries for the new classes.
The change only rename the class of hadron tensor, add comments
In order to avoid use external Eigen library, implement the TensorUtil to do hadron current. The implementation is done by claude, I do the validate to make sure the agreement at machine precision.
This is a coercive fix to address inconsistencies between the advertised number of bins (200 on p, 400 on E) and maximum range (2000 MeV on p, 500 MeV on E), and to bring p, E to be (presumed uniform) bin centres rather than bin edges. The probabilities of the files have been preserved; this only changes the bins to be compatible with what SpectralFunc assumes the format to be.
QE. A new QE vector form factor treatment (Kelly) is also added. A test CMC called GTEST23_40a_00_000 allows easy access to the new features.
…plementation HadronTensorFortInterface, now interface is general enough so in future, new implementations for any language can be added
separates the SF nuclear model development from the Fortran-dependent
… that CRPA is used for CCQE instead of the Valencia model.
sjgardiner
force-pushed
the
gardiner/sf-sbn
branch
from
July 10, 2026 21:54
06b7c51 to
336f5f6
Compare
…rged Feature/kplows tunes and fixes merged
1. Remove deprecated (and now unused) helper function
2. Mark two fatal error messages as pFATAL rather than just pERROR
3. Free memory held by spectral function TH2Ds upon destruction (note
that simply clearing the owned map does not do this automatically)
NewQELXSec when integrating the LwlynSmith and Nieves CCQE differential cross sections. Using it leads to an unphysical discontinuity in the cross-section splines.
UnifiedQELPXSec model configuration
Contributor
|
I am testing this implementation for EM. I am attempting to generate the e-Carbon spline for MEC:
This fails due to an uninitialized algorithm: You can find the full log here: Am I missing anything important for electrons? Do I need to change any configuration? I am setting up the branch as is, without extra modifications. Adding @dytman in the conversation |
- Add covariance matrix inputs under data/covariances/FormFactor/Axial/
(Deuterium, LQCD v1 and updated, MINERvA elementary target, MINERvA
Nature 2x2/4x4) and move the vector ELZExpFF.dat under
FormFactor/Vector/; document the files and their sources in a Readme
- Extend ZExpAxialFormFactorModel and ZExpELFormFactorModel to load the
covariance matrices used by the reweighting machinery
- Store importfile matrix elements at full precision in AlgConfigPool
(std::to_string's fixed 6 decimals can flip a near-singular
positive-definite covariance indefinite)
- ZExpELFormFactorModel: hard-code the Gep(0)=1 / Gen(0)=0 charges and
read the magnetic moments from the MagnMoments common parameter list
instead of per-param_set QEL-G*0 entries
- Add zexp axial param_sets: Deuterium PRD E-matrix default, minerva
and lqcd fits from arXiv:2512.14097, minervaNature from Nature 614,48
(lqcd carries the latest-version values with the v1 fit kept
commented for reference)
sjgardiner
force-pushed
the
gardiner/sf-sbn
branch
from
August 26, 2026 18:32
2d2b3ef to
d17ea3c
Compare
Add covariance matrix support to the Z-expansion form factor models
Add "unified" QE model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the spectral function nuclear model, including 40Ar treatment based on recent JLab measurements. Also adds a variant of the AR23 configuration requested by SBN that uses the new spectral function.