feat: Improve linear solvers testing - #4108
Open
victorapm wants to merge 8 commits into
Open
Conversation
victorapm
marked this pull request as ready for review
August 2, 2026 03:44
victorapm
requested review from
MelReyCG,
OmarDuran,
bd713,
cssherman,
dkachuma,
frankfeifan,
herve-gross,
jafranc,
jhuang2601,
joshua-white,
kimtaeho07,
rrsettgast and
tjb-ltk
as code owners
August 2, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds hypre/hypredrive tests to the regression suite. It adds
_mgrsmoke decks covering 25 of the 27 implemented MGR strategies (mostly derived from existing decks by switching their direct solver to gmres+MGR), of which 23 are registered in ATS. Baselines for these tests are generated byENABLE_HYPREDRV=OFFbuilds, so on a hypredrive-enabled build the same tests double as an equivalence check between the hypredrive and legacy hypre paths.Some additional details:
baselines), and unit tests asserting numerical parity of both the pure hypre and hypredrive paths.
Building these tests surfaced and fixed several real bugs:
HypredriveSolverran hypre preconditioner setup without the FPE guard the legacy path has always used, crashing a few test problems.SinglePhaseReservoirHybridFVMhad an inverted areWellsShut conditional, applying weak Jacobi relaxation to active well blocks.MGRFRelaxationType::ilusupport and an explicitly configured ILU F-solver (setILUFSolverAtLevel) so both paths use identical F-relaxation.rockylinux9-clang22image fromclang 20.1.8to22.1.3which has added-Wc2y-extensionsand leads to issues in the BLT's bundled google-benchmark. This was fixed by avoiding the c2y flag in BLT.Known limitations
singlePhasePoromechanicsConformingFracturesandthermalSinglePhasePoromechanicsReservoirFVMhave working decks included but unregistered, pendingcross-path tolerance calibration;
immiscibleMultiphaseFVMhas no deck yet.-
ALM_TFrac_mgr_smokeis commented out. Its recipe hits the 200-iteration cap on the first few solves and settles to ~50 afterwards. This happens on both solver paths, but the two endwith different non-converged counts (3 vs 4), which trips the parity check. Tuning belongs in mgrStrategies/
AugmentedLagrangianContactMechanics.hpp.-
ThermoPoroElastic_consolidation_mgr_smoke_fim(1, 2, 1) partition is dropped, keeping (1, 1, 1) so the strategy retains coverage. On two ranks the two paths take a different numberof nonlinear iterations (890 vs 1224 solves, 41% apart in total linear iterations). The answers still agree and the restart run compares clean.
Depends on GEOS-DEV/thirdPartyLibs#357