fix spark mana transfer check - #130
Open
LooseEthics wants to merge 1 commit into
Open
Conversation
5 tasks
combusterf
requested changes
Aug 8, 2026
combusterf
left a comment
combusterf
left a comment
Collaborator
There was a problem hiding this comment.
This introduces a new bug where free mana is generated when mana is between 1 and transfers-1
If you want to fix that, you also need to be careful that dispersion and balancing still works as intended.
Author
|
I think I see the problem. Will fix when I'm at my desktop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntitySpark update function has a check that only allows outgoing transfers if the total mana available for transfer is greater than the square of the number of transfers.
This feels arbitrary to the point it makes me think it's some sort of a typo. Also it makes it difficult to completely empty an object of mana.
The new logic only checks if there is any available mana to allow transfer. If the amount of mana available is less than the number of transfers, some targets get 1 point until the source runs out, the rest get nothing.