Patch Mana Enchanter

[ah-OOG-ah]

Depends on GTNewHorizons/GTNHLib#387

Switch to the GTNHLib enchantment method over the vanilla one. This fixes an issue where enchantments with level [128, 32767] get wrapped to be in [-128, 127] when enchanting with the Mana Enchanter.

[combusterf]

This

a) doesn't seem to apply to actual use cases and

b) suggests that the underlying storage or transfer is originally an actual byte, and you get corruption issues and/or secret dependencies on HodgePodge.

Code issues are:

• I can't scan for the actual changes since you inconsistently changed half the tabs into spaces
• I don't see the dependency on the latest-of-the-latest GTNHlib required for this

[ah-OOG-ah]

This

a) doesn't seem to apply to actual use cases and

Transferring uberchants beyond level 127 isn't possible without this. I don't know what you consider to be an actual usecase, but I wanted to do it and it didn't work 🤷‍♂️.

b) suggests that the underlying storage or transfer is originally an actual byte, and you get corruption issues and/or secret dependencies on HodgePodge.

The underlying storage is a short in vanilla 7.10. If it ever was a byte, this was changed in a version prior to 7.10. Working with uberchants beyond a byte doesn't seem to cause any issues in other mods allowing it (Blood Magic, Thaumic Bases).

Code issues are:

• I can't scan for the actual changes since you inconsistently changed half the tabs into spaces

Didn't intend to do that, my editor doesn't distinguish the two. Could I add a .editorconfig file to specify which one to use?

• I don't see the dependency on the latest-of-the-latest GTNHlib required for this

At the time I made the draft, it didn't exist. I'll fix the dep and undraft this.

[ah-OOG-ah]

Looks like the NHlib version has been tagged and bumped since I made this, so I'll undraft now.