Skip to content

Use external astrodata instead of repo version - #469

Open
teald wants to merge 21 commits into
masterfrom
feature/external_astrodata
Open

Use external astrodata instead of repo version#469
teald wants to merge 21 commits into
masterfrom
feature/external_astrodata

Conversation

@teald

@teald teald commented Dec 18, 2024

Copy link
Copy Markdown
Member

@teald teald added test Test suite, regression and integration tests, Jenkins. usage Usage and user interfaces component - astrodata astrodata dependencies Pull requests that update a dependency file labels Dec 18, 2024
@teald
teald force-pushed the feature/external_astrodata branch from 03d9fa7 to a840f34 Compare March 3, 2025 22:35
@teald
teald force-pushed the feature/external_astrodata branch from 59d92c5 to cab5705 Compare March 26, 2025 19:49
@teald
teald force-pushed the feature/external_astrodata branch from 929642b to 895936a Compare March 31, 2025 19:06
@codecov

codecov Bot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.77049% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.84%. Comparing base (f76cbab) to head (49f2944).

Files with missing lines Patch % Lines
gempy/gemini/gemini_tools.py 0.00% 8 Missing ⚠️
geminidr/gmos/primitives_gmos_longslit.py 0.00% 2 Missing ⚠️
gempy/scripts/typewalk.py 0.00% 2 Missing ⚠️
gemini_instruments/skycam/__init__.py 0.00% 1 Missing ⚠️
geminidr/core/primitives_image.py 0.00% 1 Missing ⚠️
recipe_system/cal_service/file_getter.py 50.00% 1 Missing ⚠️
recipe_system/cal_service/remotedb.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   46.75%   44.84%   -1.91%     
==========================================
  Files         742      724      -18     
  Lines       92064    87046    -5018     
==========================================
- Hits        43040    39036    -4004     
+ Misses      49024    48010    -1014     
Flag Coverage Δ
f2 25.81% <ø> (-2.51%) ⬇️
ghost 26.40% <ø> (-2.31%) ⬇️
ghost_integ 27.66% <ø> (-1.92%) ⬇️
gmos 26.67% <ø> (-2.01%) ⬇️
gmosls 32.18% <ø> (-2.02%) ⬇️
gnirs 27.71% <ø> (-2.11%) ⬇️
gsaoi 21.35% <ø> (-2.00%) ⬇️
igrins2 30.25% <73.77%> (-2.13%) ⬇️
niri 24.40% <ø> (-2.37%) ⬇️
regression 29.47% <ø> (-2.08%) ⬇️
slow 40.30% <ø> (-1.71%) ⬇️
unit 44.08% <ø> (-2.48%) ⬇️
wavecal 23.01% <ø> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

teald added 2 commits April 2, 2025 17:12
windowedOp -> windowed_operation
asIRAFsection -> as_iraf_section
addClass -> add_class
astrodata.open -> astrodata.from_file
@teald
teald force-pushed the feature/external_astrodata branch from 895936a to 0bc482c Compare April 3, 2025 00:15
@teald
teald marked this pull request as ready for review April 3, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - astrodata astrodata dependencies Pull requests that update a dependency file test Test suite, regression and integration tests, Jenkins. usage Usage and user interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants