fix(dtype_converter): coerce unconvertible values to na_value instead… - #112
Open
MocStepan wants to merge 1 commit into
Open
fix(dtype_converter): coerce unconvertible values to na_value instead…#112MocStepan wants to merge 1 commit into
MocStepan wants to merge 1 commit into
Conversation
jbrezmorf
reviewed
Jun 2, 2026
jbrezmorf
left a comment
jbrezmorf
left a comment
Contributor
There was a problem hiding this comment.
Po doporučených úpravách sloučit.
| return to_typed_array(arr, dtype, self._address) | ||
| except (ValueError, TypeError): | ||
| if self.na_value is None: | ||
| raise ValueError(f"Variable '{self.name}' has values not-convertible to type {dtype}.") |
Contributor
There was a problem hiding this comment.
More specific error message:
f"Can not convert input vector to variable '{self.name}' with na_value None of type {dtype}.
Input value: {the_value}"
We should report the value for which that failed, since a missing na_value may be intentional.
| def _opt_arg(arg, default): | ||
| return default if arg is None else arg | ||
|
|
||
| def _to_typed_array(self, values, dtype: Optional[np.dtype]) -> np.ndarray: |
Contributor
There was a problem hiding this comment.
Move this try directly into dtype_converter.to_typed_array, there we should catch just the np.asarray calls. That would be more specific about what is actually caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… of raising