Fix/narrow bare except handlers - #322
Merged
Merged
Conversation
Adds a "Manual test" section to instructions/delivery.md, wires it into the pre-merge step and the Implementation Definition of Done. The gap it closes: nothing currently tells the person testing a release build what to click. A changelog says what changed; it does not say what a regression would look like on screen, which is what a tester actually needs. The section has two halves -- new behaviour, and the regression surface with its symptom -- because the second is the one that gets skipped and the one that catches bugs. Two repo-specific reasons this matters more here than elsewhere, both written into the rule: - the test-ui tier is an empty harness whose Makefile target treats "no tests collected" as a pass, so anything under mapflow/dialogs/ has zero automated coverage, not merely thin coverage; - spec/004_stack.md pins CI to Linux + QGIS 3.28 LTR and states that macOS, Windows and other QGIS versions are covered by manual smoke testing only, so path, file-dialog and Qt-version-sensitive changes need an explicit callout. Notes live in the commit message rather than a tracked test-plan file. An append-only file would conflict on nearly every merge in this branch flow, since every branch appends to the same region, and its entries outlive reverts -- leaving a tester chasing behaviour that is not in the build. In the commit message the note stays welded to its diff, and only merged work contributes. The release checklist is then compiled with git log rather than maintained, so there is no cleanup commit to forget. "none" must be written explicitly: an omitted section is ambiguous between "nothing to test" and "the author forgot", and a tester cannot tell which. ## Manual test none - documentation only, no runtime code touched.
AlexeyTrekin
force-pushed
the
fix/narrow-bare-except-handlers
branch
from
August 7, 2026 13:32
82a8027 to
1db1723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.