refactor: delete the dead entity modules and the empty requests package - #325
Merged
Conversation
Phase A of the 3.7.0 refactoring (spec/007_architecture.md). Removes ~340 lines that no import reaches, so later phases move less code. The duplicate-enum question the plan flagged is settled, and the answer is that it is inert. entity/status.py is byte-identical to schema/status.py apart from one relative import, so two ProcessingStatus classes did exist at runtime, and enum members of two distinct classes never compare equal. That would be a live bug if the two could meet. They cannot: the only importer of entity/status is entity/processing, and entity/processing has no importers at all, in the plugin or the tests. mapflow/ contains no importlib, __import__ or import_module either, so nothing reaches them dynamically. The whole branch was unreachable rather than merely unused. requests/ contained a single empty __init__.py and is referenced nowhere. entity/ itself stays for now - entity/provider/ is live and moves to model/ in the next step, which is where the package disappears. ## Manual test none - the deleted modules had no importers, so no code path changes. If anything did reach them the plugin would fail to load at all, which the test suite would not miss.
AlexeyTrekin
marked this pull request as ready for review
August 11, 2026 15:22
AlexeyTrekin
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase A of the 3.7.0 refactoring (spec/007_architecture.md). Removes ~340 lines that no
import reaches, so later phases move less code.
The duplicate-enum question the plan flagged is settled, and the answer is that it is
inert. entity/status.py is byte-identical to schema/status.py apart from one relative
import, so two ProcessingStatus classes did exist at runtime, and enum members of two
distinct classes never compare equal. That would be a live bug if the two could meet. They
cannot: the only importer of entity/status is entity/processing, and entity/processing has
no importers at all, in the plugin or the tests. mapflow/ contains no importlib,
import or import_module either, so nothing reaches them dynamically. The whole branch
was unreachable rather than merely unused.
requests/ contained a single empty init.py and is referenced nowhere.
entity/ itself stays for now - entity/provider/ is live and moves to model/ in the next
step, which is where the package disappears.
Manual test
none - the deleted modules had no importers, so no code path changes. If anything did
reach them the plugin would fail to load at all, which the test suite would not miss.