Fix duplicate TARGET_LINK_LIBRARIES and duplicated DISABLE_NLP_ORACLES block - #477
Open
Omar-Abdo1 wants to merge 2 commits into
Open
Fix duplicate TARGET_LINK_LIBRARIES and duplicated DISABLE_NLP_ORACLES block#477Omar-Abdo1 wants to merge 2 commits into
Omar-Abdo1 wants to merge 2 commits into
Conversation
vissarion
reviewed
Mar 30, 2026
vissarion
left a comment
Member
There was a problem hiding this comment.
Thanks. Why not unifying the two if statements?
Author
Thanks! Good point , I missed that. I’ll unify the two if blocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three pre-existing bugs in the CMake build configuration:
new_volume_examplewas linked tolp_solvetwice:${MKL_LINK}(kept)${MKL_LINK}(removed)volume_cb_vpoly_intersection_vpolywas linked tolp_solvetwice:${MKL_LINK}(removed)${MKL_LINK}(kept)The entire
DISABLE_NLP_ORACLESoption block appeared twicein the top-level CMakeLists.txt. The duplicate block was removed.
In each case, the line with more libraries was kept to preserve
full MKL and coverage support.
No functional changes — build behavior is identical for all
existing configurations.