Skip to content

Fix duplicate TARGET_LINK_LIBRARIES and duplicated DISABLE_NLP_ORACLES block - #477

Open
Omar-Abdo1 wants to merge 2 commits into
GeomScale:developfrom
Omar-Abdo1:fix-Cmake
Open

Fix duplicate TARGET_LINK_LIBRARIES and duplicated DISABLE_NLP_ORACLES block#477
Omar-Abdo1 wants to merge 2 commits into
GeomScale:developfrom
Omar-Abdo1:fix-Cmake

Conversation

@Omar-Abdo1

Copy link
Copy Markdown

This PR fixes three pre-existing bugs in the CMake build configuration:

  1. new_volume_example was linked to lp_solve twice:

    • Once with ${MKL_LINK} (kept)
    • Once without ${MKL_LINK} (removed)
  2. volume_cb_vpoly_intersection_vpoly was linked to lp_solve twice:

    • Once without ${MKL_LINK} (removed)
    • Once with ${MKL_LINK} (kept)
  3. The entire DISABLE_NLP_ORACLES option block appeared twice
    in the top-level CMakeLists.txt. The duplicate block was removed.

In each case, the line with more libraries was kept to preserve
full MKL and coverage support.

No functional changes — build behavior is identical for all
existing configurations.

@vissarion vissarion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Why not unifying the two if statements?

@Omar-Abdo1

Omar-Abdo1 commented Mar 31, 2026

Copy link
Copy Markdown
Author

Thanks. Why not unifying the two if statements?

Thanks! Good point , I missed that. I’ll unify the two if blocks.

@Omar-Abdo1
Omar-Abdo1 requested a review from vissarion March 31, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants