Migrate poll write request bodies to generated models - #6607
Draft
gpunto wants to merge 2 commits into
Draft
Conversation
…atePollRequest, and option models
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Goal
Migrate the poll write request bodies (
createPoll,updatePoll,createPollOption,updatePollOption) to the generatedCreatePollRequest,UpdatePollRequest,CreatePollOptionRequest,UpdatePollOptionRequest,PollOptionInput, andPollOptionRequestnetwork models. Unblocked by the CHA-4436 backend fix that tags the poll requestcustomfield.Part of AND-1291
Implementation
internalpoll write-request models; remove the hand-writtenCreatePollRequest/UpdatePollRequest/UpstreamOptionDto.custom(extraData) flattened to the JSON root via aCustomObjectDtoAdapter(extraDataPropertyName = "custom")registered inMoshiChatParser;votingVisibilityuses the generated sealed class + its adapter.MoshiChatApimappers andPollsApi@Bodytypes retyped to the generated models.Testing
CreatePollRequestAdapterTest,PollOptionInputAdapterTest,PollWriteRequestAdapterTest) lock the flattened wire shape for all 6 models;MoshiChatApiTestcovers the mappers.spotlessApply,apiDump(no public-API change),detekt, and the full clienttestDebugUnitTestsuite pass.createPoll/updatePoll/createPollOption/updatePollOptioneach sendcustomflattened at root andvoting_visibility(bothanonymousandpublic); all return201and echo thecustomsentinel back.