fix(ui): Message actions background - #2860
Conversation
📝 WalkthroughWalkthroughThe PR documents local and CI golden-test workflows. It also changes the default stream dialog barrier color to ChangesGolden testing guidance
Modal scrim behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@TESTING.md`:
- Around line 216-222: Update the documented golden baseline workflow in
TESTING.md to explicitly stash the change before the first test run, restore it
with git stash pop before the second run, and include a command that compares
the baseline and regenerated golden directories. Keep the existing test commands
and paths aligned with the two-revision comparison.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6365626d-85d5-493a-bb52-94c8dd461197
📒 Files selected for processing (3)
TESTING.mdpackages/stream_chat_flutter/CHANGELOG.mdpackages/stream_chat_flutter/lib/src/misc/stream_modal.dart
| # 1. with your change reverted (git stash), regenerate and keep a copy | ||
| GITHUB_ACTIONS=true flutter test --update-goldens | ||
| cp -R <goldens/ci dirs> /tmp/baseline/ | ||
|
|
||
| # 2. restore your change, regenerate again, and diff the two sets | ||
| GITHUB_ACTIONS=true flutter test --update-goldens | ||
| ``` |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the baseline comparison executable.
Line 216 mentions git stash, but the code block does not run it. Line 220 says to restore the change, but it does not show git stash pop. If readers follow these commands as written, both runs can use the same revision and the comparison cannot isolate the PR change. Add explicit stash, restore, and comparison commands.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@TESTING.md` around lines 216 - 222, Update the documented golden baseline
workflow in TESTING.md to explicitly stash the change before the first test run,
restore it with git stash pop before the second run, and include a command that
compares the baseline and regenerated golden directories. Keep the existing test
commands and paths aligned with the two-revision comparison.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2860 +/- ##
=======================================
Coverage 72.86% 72.86%
=======================================
Files 429 429
Lines 27698 27698
=======================================
Hits 20183 20183
Misses 7515 7515 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Submit a pull request
Linear: fixes FLU-645
Linear: fixes FLU-646
CLA
Description of the pull request
The mention in notion was wrong, it should not be overlay, but scrim. That's also what's in Figma.
Might be better to merge together with a fix for FLU-647 as this seems to make the issue worse.
Screenshots / Videos
Light:
Dark:
Summary by CodeRabbit
Bug Fixes
Documentation