Build on compileSdk/targetSdk 37 (Android 17): AGP 9.1 + Gradle 9.3 + Kotlin 2.2 - #1756
Draft
rahul-lohra wants to merge 14 commits into
Draft
Build on compileSdk/targetSdk 37 (Android 17): AGP 9.1 + Gradle 9.3 + Kotlin 2.2#1756rahul-lohra wants to merge 14 commits into
rahul-lohra wants to merge 14 commits into
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
The metrics module uses the plain `io.getstream.video.android.application` convention (not the `.compose` variant), so `configureAndroidCompose()` never runs and the Compose BOM is not applied. Its compose flavors added unversioned Compose artifacts (foundation, ui, ui-tooling) whose versions come from the BOM, so resolution failed with: Could not find androidx.compose.foundation:foundation: Add the BOM platform to each compose flavor's Implementation configuration so the unversioned artifacts resolve.
rahul-lohra
changed the title
rahul-lohra
changed the title
Pointing the baseline-profile output/source dir at src/main made AGP 9's prepareReleaseArtProfile recursively parse every file under it (res webp, *.kt) as ART profile rules, failing with "Illegal token". Use the default generated/baselineProfiles dir instead.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| jobs: | ||
| base-android-ci: | ||
| uses: GetStream/stream-build-conventions-android/.github/workflows/android-ci.yml@v0.13.1 | ||
| uses: GetStream/stream-build-conventions-android/.github/workflows/android-ci.yml@feature/rahullohra/build-on-sdk-37 |
| java-version: '21' # Paparazzi 2.0.0-alpha05 requires JDK 21. | ||
| distribution: temurin | ||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v4 |
| jobs: | ||
| compare-sdk-sizes: | ||
| uses: GetStream/stream-build-conventions-android/.github/workflows/sdk-size-checks.yml@v0.13.1 | ||
| uses: GetStream/stream-build-conventions-android/.github/workflows/sdk-size-checks.yml.yml@feature/rahullohra/build-on-sdk-37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes #AND-1342
Raise compileSdk/targetSdk from 35 → 37 (Android 17). The installed platform is the stable, minor-versioned android-37.0, which the old toolchain (AGP 8.5.2) cannot even resolve (Failed to find Platform SDK … android-37). API 37 has a hard floor of AGP 9.1, and AGP 9 drops Kotlin 1.9 — so this is necessarily a full toolchain upgrade, not a one-line SDK bump.
Note: this PR depends on the GetStream/stream-build-conventions-android#70 — streamConventions must point at a published version that supports AGP 9 (currently 0.13.2-SNAPSHOT in the catalog; pin to the released version before merge).
Implementation
Describe the implementation
🎨 UI Changes
Add relevant screenshots
Testing
WIP