docs: record the deploy procedure and the host/CI toolchain split - #2
Open
GionaGranchelli wants to merge 1 commit into
Open
GionaGranchelli wants to merge 1 commit into
GionaGranchelli wants to merge 1 commit into
Conversation
The procedure existed only on the host (/root/deploy-picklinux.sh, nginx root /var/www/picklinux/app/public), so it was rediscoverable only by logging in. Also records the toolchain trap found while deploying this branch: the host runs Node 20 + pnpm 10.30.1 and CI runs Node 22 + pnpm 11.6.0, and upgrading pnpm on the host requires Node 22 at the same time (pnpm 11 needs node:sqlite).
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new deployment documentation contains an internal inconsistency about the minimum Node version required for pnpm 11, which could mislead future deployments.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds a new deployment runbook documenting the current production host layout, the manual on-host deploy script sequence, and the intentional split between host vs CI Node/pnpm toolchains.
Changes:
- Document production host paths (nginx root, git checkout, publish directory) and domain/IP mapping.
- Record the
/root/deploy-picklinux.shdeploy sequence and a detached SSH invocation pattern. - Document the host vs CI Node/pnpm versions and upgrade coupling notes.
| File | Description |
|---|---|
| docs/deploy.md | New deployment documentation covering host layout, deploy steps, and toolchain/version constraints. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,52 @@ | |||
| # Deployment | |||
|
|
|||
| whichdistro.com is a statically prerendered Nuxt app (`nitro.preset: "static"`), served by nginx | |||
Comment on lines
+39
to
+40
| If pnpm is ever upgraded on the host to 11, Node must go to 22 at the same time: pnpm 11 requires | ||
| `node:sqlite`, which landed in Node 22.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents what I had to rediscover while deploying: the live path (Linode host
tuna, nginx root/var/www/picklinux/app/public), the existing/root/deploy-picklinux.shsequence, why it is safe (it builds before swapping, so a failed build cannot take the site down), and the toolchain split — host Node 20 + pnpm 10.30.1, CI Node 22 + pnpm 11.6.0 — with the note that upgrading pnpm on the host means upgrading Node to 22 at the same time.Docs only, no code or data change.