Skip to content

fix(config): replace deprecated reflect.Ptr with reflect.Pointer - #995

Closed
hazyhaar wants to merge 1 commit into
Gitlawb:mainfrom
hazyhaar:fix/config-reflect-pointer
Closed

fix(config): replace deprecated reflect.Ptr with reflect.Pointer#995
hazyhaar wants to merge 1 commit into
Gitlawb:mainfrom
hazyhaar:fix/config-reflect-pointer

Conversation

@hazyhaar

Copy link
Copy Markdown

derefType compared t.Kind() to reflect.Ptr. That constant is deprecated; reflect.Pointer is the replacement. Behavior is unchanged.

Independent of any other open PR. Once this is on main, other branches no longer need to carry the same one-liner to satisfy govet.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 7 minutes.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e7decc0-24f0-4bf1-9cdc-23b45d4a5738

📥 Commits

Reviewing files that changed from the base of the PR and between 1b5db17 and 8433289.

📒 Files selected for processing (1)
  • internal/config/unknownfields.go

Comment @coderabbitai help to get the list of available commands.

@jatmn jatmn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandh8x

anandh8x commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Closing as a duplicate of #994, which already contains the same reflect.Ptr to reflect.Pointer change. Keeping the one-line update with the related redaction fix avoids duplicate review and a needless rebase conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants