fix: minor style/consistency cleanups#84
Merged
Conversation
- Hoist `import re` out of the per-decorator loop in _get_fastapi_route - Have fetch_commits_with_diffs accept an optional client and use the _client_ctx pattern its siblings follow, instead of always opening its own httpx.AsyncClient - Import get_embedding_provider from server.embeddings in history.py to match search.py, instead of server.embeddings.factory Fixes #80 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import reout of the per-decorator loop in_get_fastapi_route(server/parser/python.py)fetch_commits_with_diffsnow accepts an optionalclientand uses the_client_ctxpattern its siblings follow, instead of always opening its ownhttpx.AsyncClient(server/indexer/github_source.py)get_embedding_providerfromserver.embeddingsinhistory.pyto matchsearch.py's import path, instead ofserver.embeddings.factoryThe fourth item from the issue (a shared
TreeSitterParserbase class to de-duplicate boilerplate across the 21 language parsers) was intentionally left out — the issue itself flags it as lower priority since per-language node logic genuinely differs, and it's a much larger, riskier refactor better suited to its own PR.Fixes #80
Test plan
uv run pytest— 217 passed