Skip to content

[Data Validation] Max Columns Wide Row IT - #4083

Open
aasthabharill wants to merge 4 commits into
mainfrom
dv-wide-max-columns
Open

[Data Validation] Max Columns Wide Row IT#4083
aasthabharill wants to merge 4 commits into
mainfrom
dv-wide-max-columns

Conversation

@aasthabharill

@aasthabharill aasthabharill commented Jul 30, 2026

Copy link
Copy Markdown
Member

@aasthabharill aasthabharill added the addition New feature or request label Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.81%. Comparing base (4efa054) to head (566a6c5).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4083      +/-   ##
============================================
+ Coverage     56.07%   63.81%   +7.74%     
+ Complexity     7316     2686    -4630     
============================================
  Files          1127      557     -570     
  Lines         68572    31536   -37036     
  Branches       7757     3488    -4269     
============================================
- Hits          38450    20126   -18324     
+ Misses        27635    10378   -17257     
+ Partials       2487     1032    -1455     
Components Coverage Δ
spanner-templates 87.42% <ø> (ø)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 89.26% <ø> (ø)
spanner-live-reverse-replication 83.18% <ø> (ø)
spanner-bulk-migration 92.23% <ø> (ø)
gcs-spanner-dv 88.54% <ø> (ø)
see 591 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasthabharill
aasthabharill marked this pull request as ready for review July 30, 2026 13:07
@aasthabharill
aasthabharill requested a review from a team as a code owner July 30, 2026 13:07
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new integration test to ensure the GCS to Spanner Data Validation (DV) template correctly handles wide rows with up to 1024 columns. The test verifies that the system can accurately identify and report mismatches in high-column-count datasets, ensuring robustness for large-scale data validation tasks.

Highlights

  • Integration Test Addition: Added a new integration test class, GCSSpannerDVWideRowMax1024ColumnsIT, to validate data validation functionality for wide rows containing 1024 columns.
  • Validation Scenario: The test simulates a scenario with two records: one perfectly matching between Avro and Spanner, and one with a mismatched value in the 1024th column to verify detection logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new integration test class, GCSSpannerDVWideRowMax1024ColumnsIT, to validate the GCSSpannerDV template's capability to handle wide rows with up to 1024 columns. The test sets up a Spanner table and an Avro schema with 1024 columns, writes a matching record and a mismatched record (diverging at the 1024th column), runs the Dataflow pipeline, and asserts the validation results in BigQuery. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant