[Data Validation] Max Columns Wide Row IT - #4083
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
============================================
+ Coverage 56.07% 63.81% +7.74%
+ Complexity 7316 2686 -4630
============================================
Files 1127 557 -570
Lines 68572 31536 -37036
Branches 7757 3488 -4269
============================================
- Hits 38450 20126 -18324
+ Misses 27635 10378 -17257
+ Partials 2487 1032 -1455
🚀 New features to boost your workflow:
|
207bc43 to
5b546c0
Compare
5b546c0 to
51f3542
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new integration test to ensure the GCS to Spanner Data Validation (DV) template correctly handles wide rows with up to 1024 columns. The test verifies that the system can accurately identify and report mismatches in high-column-count datasets, ensuring robustness for large-scale data validation tasks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration test class, GCSSpannerDVWideRowMax1024ColumnsIT, to validate the GCSSpannerDV template's capability to handle wide rows with up to 1024 columns. The test sets up a Spanner table and an Avro schema with 1024 columns, writes a matching record and a mismatched record (diverging at the 1024th column), runs the Dataflow pipeline, and asserts the validation results in BigQuery. There are no review comments, and I have no feedback to provide.
https://docs.cloud.google.com/spanner/quotas#tables