build: update to latest import-spec version - #4084
Conversation
This includes a serializability fix for key mappings. This also includes a downgrade of the JSON schema library, which silently broke the Java 11 compatibility promise of import-spec (Dataflow works with Java 17+ so it's not an issue here, but it's an issue in other import-spec user projects). This is basically a partial revert of f22c284
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the 'import-spec' dependency and adjusts the JSON schema validation logic to ensure compatibility with Java 11. The changes involve migrating to a different version of the JSON schema library, which required updating the internal validation code and corresponding unit tests to align with the new API. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the import-spec dependency version to 1.0.0-rc21 and migrates the JSON schema validation logic in the googlecloud-to-neo4j template to use the newer JsonSchema and JsonSchemaFactory APIs from com.networknt.schema. This involves replacing legacy Schema and Error classes with JsonSchema and ValidationMessage, along with updating the corresponding unit tests to reflect the new validation message formats. There are no review comments to evaluate, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
============================================
- Coverage 56.07% 56.05% -0.02%
+ Complexity 7316 6860 -456
============================================
Files 1127 1127
Lines 68572 68573 +1
Branches 7757 7757
============================================
- Hits 38450 38437 -13
- Misses 27635 27648 +13
- Partials 2487 2488 +1
🚀 New features to boost your workflow:
|
|
Failure seems to come from |
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Thanks! Rerunning checks to try to get green before merging
3 participants
This includes a serializability fix for key mappings.
This also includes a downgrade of the JSON schema library, which silently broke the Java 11 compatibility promise of import-spec (Dataflow works with Java 17+ so it's not an issue here, but it's an issue in other import-spec user projects).
This is basically a partial revert of f22c284