Skip to content

Add migration source skills - #4091

Open
bharadwaj-aditya wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
bharadwaj-aditya:add_migration_source_skills
Open

Add migration source skills#4091
bharadwaj-aditya wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
bharadwaj-aditya:add_migration_source_skills

Conversation

@bharadwaj-aditya

Copy link
Copy Markdown
Contributor

Added skills to make addition of sources to spanner migration pipelines easier.

@bharadwaj-aditya
bharadwaj-aditya force-pushed the add_migration_source_skills branch from 8fe6129 to 1b900c7 Compare July 31, 2026 10:51
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.48%. Comparing base (64ce303) to head (88a783e).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4091      +/-   ##
============================================
+ Coverage     56.07%   62.48%   +6.40%     
+ Complexity     7317     3332    -3985     
============================================
  Files          1127      575     -552     
  Lines         68572    33708   -34864     
  Branches       7757     3700    -4057     
============================================
- Hits          38453    21063   -17390     
+ Misses        27635    11553   -16082     
+ Partials       2484     1092    -1392     
Components Coverage Δ
spanner-templates 87.42% <ø> (-0.01%) ⬇️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 89.26% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 83.18% <ø> (-0.02%) ⬇️
spanner-bulk-migration 92.23% <ø> (-0.01%) ⬇️
gcs-spanner-dv 88.54% <ø> (-0.02%) ⬇️
see 569 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bharadwaj-aditya bharadwaj-aditya added the addition New feature or request label Jul 31, 2026
@bharadwaj-aditya
bharadwaj-aditya marked this pull request as ready for review July 31, 2026 14:23
@bharadwaj-aditya
bharadwaj-aditya requested a review from a team as a code owner July 31, 2026 14:23
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces standardized operational procedures for adding new source connectors to various migration pipelines. By providing structured guides and enforcing strict prerequisite checks and resource configurations, these changes aim to streamline the development process and ensure consistent deployment behavior for Dataflow migration templates.

Highlights

  • New Migration Source Skills: Added comprehensive documentation and procedural guides for implementing new database source connectors across Datastream-to-Spanner, SourceDb-to-Spanner, and Spanner-to-SourceDb migration templates.
  • Standardized Worker Machine Requirements: Updated the functional testing skill to enforce a mandatory worker machine type (n2-standard-4) for Dataflow jobs to prevent validation failures during template launches.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@bharadwaj-aditya
bharadwaj-aditya requested review from dhwanilpatel and removed request for aasthabharill July 31, 2026 14:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new agent skill guides (SKILL.md) for implementing database source connectors across different Dataflow templates: datastream-to-spanner, sourcedb-to-spanner, and spanner-to-sourcedb. It also updates the global agent rules for functional testing to enforce explicit worker machine type configurations (defaulting to n2-standard-4 with at least 4 vCPUs) when submitting Dataflow jobs. Since there are no review comments, I have no additional feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant