Add migration source skills - #4091
Conversation
8fe6129 to
1b900c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4091 +/- ##
============================================
+ Coverage 56.07% 62.48% +6.40%
+ Complexity 7317 3332 -3985
============================================
Files 1127 575 -552
Lines 68572 33708 -34864
Branches 7757 3700 -4057
============================================
- Hits 38453 21063 -17390
+ Misses 27635 11553 -16082
+ Partials 2484 1092 -1392
🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces standardized operational procedures for adding new source connectors to various migration pipelines. By providing structured guides and enforcing strict prerequisite checks and resource configurations, these changes aim to streamline the development process and ensure consistent deployment behavior for Dataflow migration templates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces three new agent skill guides (SKILL.md) for implementing database source connectors across different Dataflow templates: datastream-to-spanner, sourcedb-to-spanner, and spanner-to-sourcedb. It also updates the global agent rules for functional testing to enforce explicit worker machine type configurations (defaulting to n2-standard-4 with at least 4 vCPUs) when submitting Dataflow jobs. Since there are no review comments, I have no additional feedback to provide.
Added skills to make addition of sources to spanner migration pipelines easier.