Skip to content

Support external_ip flag for gce_vm_image_export - #218

Merged
shtarkmang merged 3 commits into
GoogleCloudPlatform:mainfrom
bpl4vv:external_ip_flag
Aug 27, 2026
Merged

Support external_ip flag for gce_vm_image_export#218
shtarkmang merged 3 commits into
GoogleCloudPlatform:mainfrom
bpl4vv:external_ip_flag

Conversation

@bpl4vv

@bpl4vv bpl4vv commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

In a similar vein to #185, GCE Image Export Tool spins up a temporary VM while performing image export. This VM is often created with an external IP address.

This CL provides a flag so that the temporary VM can be created with a static external IP, an ephemeral IP, or no external IP.

@google-oss-prow
google-oss-prow Bot requested a review from advazair August 22, 2026 16:02
@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bpl4vv
Once this PR has been reviewed and has the lgtm label, please assign advazair for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot requested a review from ycohen278 August 22, 2026 16:02
@google-oss-prow google-oss-prow Bot added size/L and removed size/M labels Aug 22, 2026
@google-oss-prow

Copy link
Copy Markdown

@bpl4vv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
prow/presubmit/gocheck/cli-tools 628a448 link true /gocheck-cli-tools
prow/presubmit/gotest/cli-tools 628a448 link true /gotest-cli-tools
prow/presubmit/gobuild/cli-tools 628a448 link true /gobuild-cli-tools
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shtarkmang
shtarkmang merged commit 1a12a78 into GoogleCloudPlatform:main Aug 27, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants