feat(googlecloudk8scommon): default kind filter to all kinds except leases - #975
Merged
Merged
Conversation
kyasbal
requested review from
K53,
RyuSA,
jyane,
kkuchima and
renamoo
as code owners
September 9, 2026 02:46
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the InputKindFilterTask to change its default value from @default to ["@any", "-leases"] and renames the @default alias to @legacy_default. It also adds comprehensive unit tests for the InputKindFilterTask and updates existing test configurations to use the new @legacy_default alias. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Kubernetes resource kind filter default value and alias in
InputKindFilterTask:@defaultto[]string{"@any", "-leases"}.@defaultalias with@legacy_defaultto prevent semantic drift, maintaining the curated list of legacy kinds under an explicit retrospective name and avoiding hyphen confusion with the subtractive filter-.inputkindfilter_task_test.gocovering metadata, default values, subtractive filtering, alias expansion, custom inputs, and validation errors.parser_test.goto use@legacy_default.Test Plan
make lint-go(passed with 0 issues).go test -v ./pkg/task/inspection/googlecloudk8scommon/impl/... ./pkg/task/inspection/googlecloudlogk8saudit/impl/...(passed).make test-go(all backend test suites passed).make pre-commit(all linters and formatters passed).