Skip to content

feat(googlecloudk8scommon): default kind filter to all kinds except leases - #975

Merged
kyasbal merged 1 commit into
GoogleCloudPlatform:mainfrom
kyasbal:push-kkzmtkyoxplz
Sep 9, 2026
Merged

feat(googlecloudk8scommon): default kind filter to all kinds except leases#975
kyasbal merged 1 commit into
GoogleCloudPlatform:mainfrom
kyasbal:push-kkzmtkyoxplz

Conversation

@kyasbal

@kyasbal kyasbal commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Updates the Kubernetes resource kind filter default value and alias in InputKindFilterTask:

  • Updates the default filter value from @default to []string{"@any", "-leases"}.
  • Replaces the @default alias with @legacy_default to prevent semantic drift, maintaining the curated list of legacy kinds under an explicit retrospective name and avoiding hyphen confusion with the subtractive filter -.
  • Introduces comprehensive unit tests in inputkindfilter_task_test.go covering metadata, default values, subtractive filtering, alias expansion, custom inputs, and validation errors.
  • Updates the audit log benchmark fixture config in parser_test.go to use @legacy_default.

Test Plan

  • Run make lint-go (passed with 0 issues).
  • Run go test -v ./pkg/task/inspection/googlecloudk8scommon/impl/... ./pkg/task/inspection/googlecloudlogk8saudit/impl/... (passed).
  • Run make test-go (all backend test suites passed).
  • Run make pre-commit (all linters and formatters passed).

@kyasbal kyasbal added type:feature New feature or request area:backend-core Core backend frameworks, DAG task runner, and server API area:backend-parser Log parsers and log timeline mapper tasks labels Sep 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the InputKindFilterTask to change its default value from @default to ["@any", "-leases"] and renames the @default alias to @legacy_default. It also adds comprehensive unit tests for the InputKindFilterTask and updates existing test configurations to use the new @legacy_default alias. There are no review comments, so I have no feedback to provide.

@kyasbal
kyasbal enabled auto-merge September 9, 2026 02:49
@kyasbal
kyasbal added this pull request to the merge queue Sep 9, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 3162d4e Sep 9, 2026
17 checks passed
@kyasbal
kyasbal deleted the push-kkzmtkyoxplz branch September 9, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend-core Core backend frameworks, DAG task runner, and server API area:backend-parser Log parsers and log timeline mapper tasks type:feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant