fix(inspection): resolve timezone offset fallback to UTC by unifying to timezoneShiftHours - #978
Merged
Merged
Conversation
…to timezoneShiftHours Following the Connect-RPC migration (GoogleCloudPlatform#908), the timezone shift parameter was updated in Protobuf and backend RPC handlers to timezoneShiftHours (float64). However, TimeZoneShiftInputTask and the frontend InspectionClient retained references to the legacy timezoneShift key, causing inspections to always fall back to UTC time. This change: - Unifies the context key to TaskInputKeyTimezoneShiftHours in inspectioncore - Updates TimeZoneShiftInputTask to read TaskInputKeyTimezoneShiftHours - Updates backend-api.service.ts and its test to use timezoneShiftHours - Updates parser_test.go to float64(9) - Adds unit tests for TimeZoneShiftInputTask
K53
requested review from
RyuSA,
jyane,
kkuchima,
kyasbal and
renamoo
as code owners
September 9, 2026 09:13
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the timezone shift parameter handling by renaming the parameter from "timezoneShift" to "timezoneShiftHours" across both the frontend and backend codebases. It introduces a central constant TaskInputKeyTimezoneShiftHours in the backend contract, simplifies the timezone shift parsing logic in TimeZoneShiftInputTask, and adds a comprehensive suite of unit tests for this task. All references in tests and API clients have been updated accordingly. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Following the Connect-RPC migration (#908), the timezone shift parameter was changed to
timezoneShiftHours. However, references to the legacytimezoneShiftkey remained inTimeZoneShiftInputTaskand the frontend client, causing timezone offsets to always fall back to UTC.What changed
Ensured that browser/request timezone offsets are correctly propagated to
TimeZoneShiftInputTask, so that inspection form defaults (such as End time) and log queries properly reflect the local timezone instead of defaulting to UTC. Also added unit tests forTimeZoneShiftInputTask.