[confgenerator] Migrate important Self Log signals to Otel Logging. - #2389
Open
franciscovalentecastro wants to merge 19 commits into
Open
[confgenerator] Migrate important Self Log signals to Otel Logging.#2389franciscovalentecastro wants to merge 19 commits into
franciscovalentecastro wants to merge 19 commits into
Conversation
franciscovalentecastro
changed the title
franciscovalentecastro
force-pushed
the
fcovalente-otel-self-logs
branch
from
July 30, 2026 02:03
bce95c1 to
9c76ee0
Compare
Contributor
|
Can you make sure the tests are passing here? I see TestLoggingSelfLogs is failing |
| } | ||
|
|
||
| agentSelfMetrics := AgentSelfMetrics{ | ||
| AgentSelfMetrics := AgentSelfMetrics{ |
Contributor
There was a problem hiding this comment.
is this supposed to be upperacse or lowercase?
Contributor
Author
There was a problem hiding this comment.
Lower case, i'll update.
| } | ||
|
|
||
| func (uc *UnifiedConfig) GenerateOtelConfig(ctx context.Context, outDir, stateDir string) (string, error) { | ||
| func (uc *UnifiedConfig) GenerateOtelConfig(ctx context.Context, logsDir, stateDir, outDir string) (string, error) { |
Contributor
There was a problem hiding this comment.
Was the change in the order here intentional?
Contributor
Author
There was a problem hiding this comment.
Ohhhh man! Thanks for letting me know! I brushed that change off after doing "Gemini please refactor the method with logsDir", but didn't realize the order was updated :o . Bad AI.
franciscovalentecastro
force-pushed
the
fcovalente-otel-self-logs
branch
from
August 5, 2026 15:18
be3e262 to
0831ff3
Compare
Contributor
Author
I fixed the bug in |
franciscovalentecastro
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors fluent-bit self log pipelines and coverts them into default on Otel Logging pipelines. This are the two log signals that are refactored :
health_checks.log: This file is tailed and structured to have some labels about the agent.Logging Ping: This is aDEBUGlog that is sent every 10 minutes to verify GCL logs export is working.This signals should the have the following labels :
The tailing of "logging_module.log" is left as a Fluent-bit Pipeline which will be deleted in Ops Agent 3.0.
Related issue
b/540427023
How has this been tested?
Checklist: