Fix credential persistence deadlock and bound login network waits - #3
Open
ameel wants to merge 1 commit into
Open
Fix credential persistence deadlock and bound login network waits#3ameel wants to merge 1 commit into
ameel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth login can hang indefinitely at several points, and credential persistence deadlocks after Spotify has already accepted the session.
The deadlock occurs in
__authenticate_partial(): it receives and storesAPWelcome, then callscredentials()before releasing the authentication condition.credentials()callsap_welcome(), which waits on that same condition, so the login thread waits on itself. This change reads the already-received welcome packet directly while persisting reusable credentials.The change also:
Validation: