fix: stop Freaky Forester pheasants granting combat experience - #1109
Merged
GregHib merged 1 commit intoJul 30, 2026
Merged
Conversation
Add a combat_exp npc definition flag, checked in CombatExperience.grant, and disable it for all pheasant variants so killing them during the random event gives no combat or Constitution xp.
GregHib
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Killing pheasants during the Freaky Forester random event grants full combat experience (attack style xp + Constitution), which can disrupt goals for skiller builds. On rs wiki behavior the event pheasants give no combat experience.
Solution
combat_expnpc definition param (defaulttrue), checked once inCombatExperience.grantso all xp paths (melee/magic/range, Constitution, familiars) respect it.combat_exp = falseon the pheasant base definition; all variants inherit it viaclone.Testing
truethe test fails at the xp assertion, so the guard is what's being exercised.FreakyForesterTestandCombatTestsuites pass.