Skip to content

fix: stop Freaky Forester pheasants granting combat experience - #1109

Merged
GregHib merged 1 commit into
GregHib:mainfrom
HarleyGilpin:fix/freaky-forester-disable-combat-xp
Jul 30, 2026
Merged

fix: stop Freaky Forester pheasants granting combat experience#1109
GregHib merged 1 commit into
GregHib:mainfrom
HarleyGilpin:fix/freaky-forester-disable-combat-xp

Conversation

@HarleyGilpin

@HarleyGilpin HarleyGilpin commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Problem

Killing pheasants during the Freaky Forester random event grants full combat experience (attack style xp + Constitution), which can disrupt goals for skiller builds. On rs wiki behavior the event pheasants give no combat experience.

Solution

  • Adds a combat_exp npc definition param (default true), checked once in CombatExperience.grant so all xp paths (melee/magic/range, Constitution, familiars) respect it.
  • Sets combat_exp = false on the pheasant base definition; all variants inherit it via clone.
  • The flag is reusable for any other npc that shouldn't give combat xp.

Testing

  • New WorldTest: kills a pheasant through real combat and asserts Attack/Strength/Constitution experience is unchanged.
  • Negative-checked: with the flag flipped to true the test fails at the xp assertion, so the guard is what's being exercised.
  • Existing FreakyForesterTest and CombatTest suites pass.

Add a combat_exp npc definition flag, checked in CombatExperience.grant,
and disable it for all pheasant variants so killing them during the
random event gives no combat or Constitution xp.
@GregHib
GregHib merged commit 051fb55 into GregHib:main Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants