FIX: keep package-source in git so a clone can composer install - #52
Open
allrude wants to merge 1 commit into
Open
FIX: keep package-source in git so a clone can composer install#52allrude wants to merge 1 commit into
allrude wants to merge 1 commit into
Conversation
git cannot track an empty directory, so a project created by mage loses its package-source folder on clone and composer install aborts with "the url supplied for the path (package-source/*/*) repository does not exist". A .gitkeep marker keeps the folder present. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A project created by
magecannot be cloned and set up again, becausepackage-sourcedisappears.mage installregisterspackage-source/*/*as a Composerpathrepository and creates the folder, but git cannot track an empty directory. After a clone the folder is gone andcomposer installaborts before installing anything:This adds a
.gitkeepmarker next to themkdir -p, so the folder survives a clone.Found while setting up a store from a fresh clone on a second machine. Only
src/is touched, the builtmageis left for a release as usual.One thing worth flagging for #47: its
.gitignorelists/package-source/, which would ignore this marker and bring the problem back. Ignoring/package-source/*with a!/package-source/.gitkeepnegation keeps the packages untracked while letting the folder survive.